Repository navigation
Reject top-k queries with k greater than the number of indexed series - #83
Merged
Merged
Conversation
Messi, Sofa, Fresh and Sing padded missing top-k slots by repeating the last neighbor; ParIS, Coconut and Hercules returned placeholder ids; and BruteForce, LbBruteforce, DumpyOS and Odyssey only printed an error and returned without writing results. Add SimilaritySearchAlgorithm::checkTopKNotGreaterThanDatabase, which throws std::invalid_argument (ValueError in Python), and call it from every top-k entry point, including SearchConfig top-k and Coconut's searchIndexRecent. k == n keeps working, and the limit follows streaming inserts. Add C++ and Python tests covering every algorithm built by default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ubuntu-latest moved to Ubuntu 26.04 (image 20261101), and auditwheel
refuses to repair a wheel built with that toolchain into a manylinux
tag ("too-recent versioned symbols"). The last green release dry-run
ran on ubuntu-24.04. Pin both the dry-run and the PyPI publish job so
the next release builds a publishable wheel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On ubuntu-latest, now Ubuntu 26.04, nine HerculesRange RandomWalk tests and CoconutTest.QueryBoundLookupMatchesReferenceAndPrunesSafely fail, while the same tests pass on ubuntu-24.04 (last green run: 290/290). None of them exercise code changed on this branch. Pin ci and simple-ci like the release workflows so CI is green again; the 26.04 failures need a separate fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messi, Sofa, Fresh and Sing padded missing top-k slots by repeating the last neighbor; ParIS, Coconut and Hercules returned placeholder ids; and BruteForce, LbBruteforce, DumpyOS and Odyssey only printed an error and returned without writing results.
Add SimilaritySearchAlgorithm::checkTopKNotGreaterThanDatabase, which throws std::invalid_argument (ValueError in Python), and call it from every top-k entry point, including SearchConfig top-k and Coconut's searchIndexRecent. k == n keeps working, and the limit follows streaming inserts.
Add C++ and Python tests covering every algorithm built by default.